Pass ServiceCIDR to controller-manager #797
Conversation
In theory PodCIDR and ServiceCIDR can overlap, letting controller-manager know service cidr allows it to behave correctly in that case
|
Can one of the admins verify this patch? |
2 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
k8s-ci-robot
added
the
cncf-cla: yes
|
Can one of the admins verify this patch? |
k8s-ci-robot
added
the
size/XS
Do people actually do this? Are there any other benefits from passing this flag or is it just to make this case work? |
How is that defined? Overlapping ranges will surely produce collisions, is the controller trusted to detect and use only the non-overlapping parts of the range? |
|
@dghubble , yes it is blocking overlapping part, see https://github.com/kubernetes/kubernetes/blob/v1.8.4/pkg/controller/node/ipam/range_allocator_test.go#L75-L96 |
I don't know if people do it or not, but AFAIK it is supported configuration and there is no harm passing extra flag. |
|
coreosbot run e2e |
* controller-manager can handle overlapping pod and service CIDRs to avoid address collisions, if its informed of both ranges * Still favor non-overlapping pod and service ranges of course * kubernetes-retired/bootkube#797
In theory PodCIDR and ServiceCIDR can overlap, letting controller-manager
know service cidr allows it to behave correctly in that case